Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set allValue for all variables with includeAll #100

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

yuvipanda
Copy link
Collaborator

A follow-up to #91, as the openscapes community reported this is causing issues not just for the $hub variable but everything else as well.

#90 is the long term fix

A follow-up to jupyterhub#91,
as the openscapes community reported this is causing issues
not just for the $hub variable but everything else as well.

jupyterhub#90 is
the long term fix
@consideRatio consideRatio added the bug Something isn't working label Feb 29, 2024
@consideRatio consideRatio changed the title Explicitly set allowAll for all variables includeAll Explicitly set allValue for all variables with includeAll Feb 29, 2024
Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I fixed the title, if it looks good to you, then feel free to go for a merge!

@yuvipanda yuvipanda merged commit f9fd032 into jupyterhub:main Feb 29, 2024
1 check passed
@yuvipanda
Copy link
Collaborator Author

Thanks @consideRatio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants